map some additional orcid pub types #1438
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
force-pushed
the
map-additional-orcid-types
branch
from
00a4d5c
to
5829fcf
Compare
peetucket
commented
Mar 11, 2022
| def orcid_pub? | ||
| provenance == Settings.orcid_source | ||
| end | ||
|
|
||
| def wos_pub? |
There was a problem hiding this comment.
additional convenience method like we have for other sources
peetucket
commented
Mar 11, 2022
| 'inproceedings' => 'conference-paper', | ||
| 'otherPaper' => 'other', | ||
| 'technicalReport' => 'report', | ||
| 'workingPaper' => 'working-paper' | ||
| }.freeze |
There was a problem hiding this comment.
the extra mappings from ORCID works to pub types in sul-pub
peetucket
commented
Mar 11, 2022
| @@ -21,7 +21,7 @@ def map | |||
| title: work.title, | |||
| identifier: map_identifiers(work.self_external_ids), | |||
| abstract: work.short_description, | |||
| provenance: 'orcid', | |||
| provenance: Settings.orcid_source, | |||
| doi: work.external_id_value('doi'), | |||
There was a problem hiding this comment.
this matches how we set provenance for other source types
peetucket
commented
Mar 11, 2022
| - otherPaper # Only set via manual pub submission (provenance = cap) or via ORCID harvest (provenance = orcid) | ||
| - technicalReport # Only set via manual pub submission (provenance = cap) or via ORCID harvest (provenance = orcid) | ||
| - workingPaper # Only set via manual pub submission (provenance = cap) or via ORCID harvest (provenance = orcid) | ||
| - null # Legacy. Not in current code, likely bad data. | ||
| wos_item_id: |
There was a problem hiding this comment.
updates to documentation
peetucket
commented
Mar 11, 2022
| @@ -108,7 +108,7 @@ | |||
|
|
|||
| context 'when unmappable type' do | |||
| let(:pub_hash) do | |||
| base_pub_hash.dup.tap { |pub_hash| pub_hash[:type] = 'workingPaper' } | |||
| base_pub_hash.dup.tap { |pub_hash| pub_hash[:type] = nil } | |||
| end | |||
There was a problem hiding this comment.
workingPaper is now mappable so let's use some other bad data type to prove we raise the error
peetucket
force-pushed
the
map-additional-orcid-types
branch
3 times, most recently
from
7f26b6f
to
bae32ac
Compare
peetucket
force-pushed
the
map-additional-orcid-types
branch
from
bae32ac
to
c92a741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
We should be able to map additional ORCID types - will be useful when we harvest works from ORCID. Started by looking at the list of works at ORCID and mapping a few more that we can support with our data model.
Also, some changes to match the pattern of other publication sources.
How was this change tested?
Existing tests
Which documentation and/or configurations were updated?